cloudability / metrics-agent

From the cloud optimization professionals
https://www.cloudability.com/
Apache License 2.0
39 stars 35 forks source link

adding pod annotions and readonlyrootfilesystem capabilities #260

Closed GyunCho closed 3 months ago

GyunCho commented 4 months ago

What does this PR do?

Add podAnnotations and containers. securityContext.readOnlyRootFilesystem capabilities, so that they can be added or modified for metrics-agent's deployment manifest

Where should the reviewer start?

deployment.yaml

How should this be manually tested?

For annotation, in values file, add new podAnnotations and check if it's added in a metrics-agent pod. For readOnlyRootFilesystem, change readOnlyRootFilesystem value to true and check if it's changed in a metrics-agent pod.

Any background context you want to provide?

Our organization highly values security vulnerability and tracking, and these capabilities are needed to comply with that.

What picture best describes this PR (optional but encouraged)?

What are the relevant Github Issues?

Developer Done List

For the Reviewer:

By approving this PR, the reviewer acknowledges that they have checked all items in this done list.

Reviewer/Approval Done List

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

daniel-spray commented 3 months ago

Thanks for your contribution, these changes were included in https://github.com/cloudability/metrics-agent/pull/261