Closed daniel-spray closed 4 months ago
@daniel-spray Oh thanks Daniel for opening this PR! I definitely missed making changes to some other files like Chart.yaml.
Btw, can you also include this change please? readOnlyRootFilesystem: {{ .Values.readOnlyRootFilesystem }}
I will need to set readOnlyRootFilesystem: true to prevent root filesystem having more than read permission. After this, one will need to set emptyDir, but I thought that's up to a user.
I also tested this works without any issue
What does this PR do?
Adds optional annotations to the helm chart deployment
Where should the reviewer start?
helm chart configs
How should this be manually tested?
Deployed on a test cluster where Values.yaml podAnnotations was empty. Also deployed where podAnnotations contained an annotation
Any background context you want to provide?
Shout out to @Gyuncho for the pull request! https://github.com/cloudability/metrics-agent/pull/260
What picture best describes this PR (optional but encouraged)?
What are the relevant Github Issues?
Developer Done List
For the Reviewer:
By approving this PR, the reviewer acknowledges that they have checked all items in this done list.
Reviewer/Approval Done List