cloudacy / vue-markdown-render

A simple markdown parser for Vue using markdown-it.
MIT License
79 stars 10 forks source link

export type instead of export #20

Closed jakudlaty closed 11 months ago

jakudlaty commented 11 months ago

Hi I am trying to use Your library with isolatedModules in my tsconfig an this gives me an warning:

node_modules/vue-markdown-render/src/VueMarkdown.ts:3:10 - error TS1205: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.

export { Options } from 'markdown-it'
              ~~~~~~~

i think it should be

export type { Options } from 'markdown-it'

To provide more compatibility.

jakudlaty commented 11 months ago

It builds without problems.

pnpm run build

> vue-markdown-render@2.1.0 build /home/jakudlaty/Devel/vue-markdown-render
> tsc

I see You dont have any CI on your project, You know that github ci is free for opensource projects? Maybe i could help You create a basic CI worklow which at least runs a npm build for every pull request?

p-kuen commented 11 months ago

I see You dont have any CI on your project, You know that github ci is free for opensource projects?

Yes, unfortunately I had no time to implement ci for this project.

I see You dont have any CI on your project, You know that github ci is free for opensource projects? Maybe i could help You create a basic CI worklow which at least runs a npm build for every pull request?

Yes, I would appreciate it a lot if you could create a PR for building the package.

It builds without problems.

Thanks, can you please commit the built files into the PR until we have a running CI?

jakudlaty commented 11 months ago

Thanks, can you please commit the built files into the PR until we have a running CI?

done