search

cloudamqp / amqproxy

An intelligent AMQP proxy, with connection and channel pooling/reusing
https://www.cloudamqp.com
MIT License
342 stars 50 forks source link

Normalize error logs to all provide the exception object #158

Closed Blacksmoke16 closed 4 months ago

Blacksmoke16 commented 4 months ago

Resolves my comment from https://github.com/cloudamqp/amqproxy/commit/98c0bc7bdc2509d62c2191bc3038ce8ddcb0563d#r138864701. Ensures all error logging passes the exception object via the named arg vs in the message.

dentarg commented 4 months ago

I think this has the potential to make the logs more verbose and scarier than we want. We should judge each case individually if it needs the backtrace.

carlhoerberg commented 4 months ago

We only want to log the stacktrace when it's an unhandled exception, there's no need to print the stacktrace when we handle the exception.