search

cloudamqp / amqproxy

An intelligent AMQP proxy, with connection and channel pooling/reusing
https://www.cloudamqp.com
MIT License
351 stars 54 forks source link

Debian 10 - Upgrading replaces service file so requires manual changes after patching #89

Closed madhancock closed 1 year ago

madhancock commented 2 years ago

We recently upgraded from 0.5.6 to 0.7.0.

This upgrade apparently replaced the /etc/systemd/system/amqproxy.service file which needs to be modified to include the target rabbitmq service which subsequently turned maintenance into an outage.

I can see there's some level of .ini support but it's not documented in the readme file and it's unclear without actually using it how it behaves with the .service file. E.g. does it override the defaults included in the service file? - If it doesn't then if the service file is reset the ini file isn't going to protect the configuration state.

carlhoerberg commented 2 years ago

For changes to the service file you should create an override.conf, preferably using systemctl edit amqproxy, that will not be overwritten by any packet changes/upgrades.

timothyclarke commented 1 year ago

@carlhoerberg I've just installed 0.8.1-1 from package cloud per the readme and the systemd service still has ExecStart=/usr/bin/amqproxy -p 5673 amqp://127.0.0.1:5672

There is an example service and example config can we get that in the deb package (with the ini tagged as a config file) instead of the override.conf method above ?

carlhoerberg commented 1 year ago

Yes, will come with the next release.

timothyclarke commented 1 year ago

@carlhoerberg If the next release is going to be a while away, is there any chance of getting 0.8.1-2 with the systemd changes sooner ?

carlhoerberg commented 1 year ago

Available in the Artifacts here: https://github.com/cloudamqp/amqproxy/actions/runs/3544098825