Push the "latest" tag to Docker Hub when we tag a release

[dentarg]

The change in #214 didn't help, no latest tag at https://github.com/84codes/avalanchemq/runs/1748367503?check_suite_focus=true#step:8:7

Not sure why it didn't work... we do checkout the full history:

https://github.com/84codes/avalanchemq/blob/82c2882c6bed21c365838d46c3e3b7facd8694fd/.github/workflows/docker.yml#L14-L17

[antondalgren]

Related to #217 ?

[dentarg]

No, we have had this problem going back some months, if you don't specify any tag when doing docker pull cloudamqp/avalanchemq, Docker will fetch the image for the default tag, which is latest. Right now that's a 2 months old image: https://hub.docker.com/r/cloudamqp/avalanchemq/tags?page=1&name=latest

[carlhoerberg]

The problem is that the most recent releases aren't "annotated" tags:

➜  avalanchemq git:(main) ✗ git describe --tags
v1.0.0-alpha.23
➜  avalanchemq git:(main) ✗ git describe
v1.0.0-alpha.19-114-g82c2882c
➜  avalanchemq git:(main) ✗ git describe --exact-match
fatal: no tag exactly matches '82c2882c6bed21c365838d46c3e3b7facd8694fd'

To make a release one have to do git tag -a v1.0.0-alpha.24 and then write a tag message (like a commit message), where i normally put in change log for that version.

[dentarg]

Ah so we need to document the release procedure so we all do the same every time :)

Also, should we be creating releases here on GitHub? (It is very easy to trigger action workflows that happen when a release is created)

[carlhoerberg]

a github release is automatically created when you do an annotated tag :)

[carlhoerberg]

updated release instructions: https://github.com/cloudamqp/avalanchemq#release

[dentarg]

The tags are listed under releases

but they don't seem to be treated as "real" releases, this is what shown in the sidebar on the front page:

So might be worthwhile doing them?

[carlhoerberg]

oh, you're right, probably use https://github.com/marketplace/actions/create-a-release for that then.

[dentarg]

latest tag now updated 🎉 https://hub.docker.com/r/cloudamqp/avalanchemq/tags?page=1&name=latest&ordering=last_updated

[carlhoerberg]

Yes, and we now only push to docker hub on v* tags, not every build

On Tue, Jan 26, 2021 at 9:05 AM Patrik Ragnarsson notifications@github.com wrote:

Closed #219 https://github.com/cloudamqp/avalanchemq/issues/219.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cloudamqp/avalanchemq/issues/219#event-4249384434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABL6TRMZUKVGSKLLK3XUULS3ZZSZANCNFSM4WOPXWDQ .