Hey there, when installing the CloudAMQP provider plugin i bumped into a few things in the install steps that didn't really work on my linux system, and some things that seemed off about the documentation and things around the project.
Directories that are needed for the build and release make targets will now be created before they are needed. (If they already exist, nothing happens)
I checked in the Gopkg.lock file since the file is needed in order to use the make depsupdate target at all. Note: I have not validated that all the package versions are compatible and that everything works. I beleive that the Gopkg.lock file should be checked in, so that the version sets are not changing without the devs actually having made sure that the newer versions work.
I added the -v flag to the command that is run by make depsupdate so that the user can see that things are happening. (The command ran for a long time for me and i wasn't sure if anything was actually happening)
I changed the download instructions for cloudamqp/terraform-provider-cloudamqp so that we are using go get instead of having to mess around with creating and downloading everything manually.
I changed the last step from make init to make install since i don't really understand what we are trying to do with the init...
I hope that at least most of this is useful. Please feel free to ask questions or challange what i am suggesting. Cheers and thanks! :)
Fixes #26
Hey there, when installing the CloudAMQP provider plugin i bumped into a few things in the install steps that didn't really work on my linux system, and some things that seemed off about the documentation and things around the project.
build
andrelease
make targets will now be created before they are needed. (If they already exist, nothing happens)make depsupdate
target at all. Note: I have not validated that all the package versions are compatible and that everything works. I beleive that the Gopkg.lock file should be checked in, so that the version sets are not changing without the devs actually having made sure that the newer versions work.-v
flag to the command that is run bymake depsupdate
so that the user can see that things are happening. (The command ran for a long time for me and i wasn't sure if anything was actually happening)make init
tomake install
since i don't really understand what we are trying to do with the init...I hope that at least most of this is useful. Please feel free to ask questions or challange what i am suggesting. Cheers and thanks! :)