search

cloudamqp / terraform-provider-cloudamqp

Terraform Provider for CloudAMQP
https://registry.terraform.io/providers/cloudamqp/cloudamqp
Mozilla Public License 2.0
35 stars 38 forks source link

Update integration resource docs for version tags #277

Closed insanedefaults closed 6 months ago

insanedefaults commented 6 months ago

Related to issue #276.

The tags attribute for cloudamqp_integration_log and cloudamqp_integration_metric offer the ability to add tags- useful for cases like USM with Datadog. The version tag requires that the version be prefixed with the letter v. This change updates the docs to reflect that. It also adds them to the tests to ensure this is documented in the code, even if the validation takes place on the underlying API.

tbroden84 commented 6 months ago

Thanks for the contribution, added a suggestion above. Since this is related only to Datadog integration. Have updated our API documentation with this. Had a thought that I will discuss internally if the layout later should changes for both integrations pages. Instead of listing all arguments, divide them into separated integration types instead. E.g. Datadog will get it's own section with a sub-header and only related arguments and information.

tbroden84 commented 6 months ago

Did some changes and will merge this. Documents at registry will be update after the next release. Thanks again to pointing this out and creating this PR.