search

cloudamqp / terraform-provider-cloudamqp

Terraform Provider for CloudAMQP
https://registry.terraform.io/providers/cloudamqp/cloudamqp
Mozilla Public License 2.0
35 stars 39 forks source link

Initial migration to Terraform Plugin Framework #279

Open tete17 opened 5 months ago

tete17 commented 5 months ago

This is the first of many resources to be migrated to the Hashicorp Plugin Framework.

I chose this one because it was the smallest file that still contained test to make sure I could prove nothing had changed.

This 3 MR does 3 things:

Note: Review should be much simpler commit by commit

Hopefully this migration will allow us to tackle issues like https://github.com/cloudamqp/terraform-provider-cloudamqp/issues/214

The error messages are fairly barebones as I haven't given them too much though feel free to suggest a full rewrite on them, I focused on making the main path work, error messages are mostly an afterthought.

dentarg commented 5 months ago

Do you want to rebase? Seeing you make such nice commits I'm hesitant to click the Update branch button :-)

tbroden84 commented 5 months ago

Thanks for the contribution, very appreciated. After internal discussions and how we want to prioritize our work. Migrating to framework will be put on hold until August/September to finish our other tasks before the summer. We will definitely keep an eye of any changes here.

tete17 commented 5 months ago

Thanks for the feedback @tbroden84

I understand the concern of merging this right away. I was just trying to fix https://github.com/cloudamqp/terraform-provider-cloudamqp/issues/214 as soon as I could as it is something that affects the infra I manage for my employee.

I will continue rebasing this MR as it is required. Ping me if you would like some help in other places

tete17 commented 1 month ago

Hi @tbroden84 & @dentarg

I just rebased the branch again, let me know if you need something from my end :)

tbroden84 commented 1 month ago

@tete17 thanks. Expect small fixes to the provider we unfortunately still have this task on hold until later. Currently internal tasks that are higher prioritized.