cloudamqp / terraform-provider-cloudamqp

Terraform Provider for CloudAMQP
https://registry.terraform.io/providers/cloudamqp/cloudamqp
Mozilla Public License 2.0
35 stars 39 forks source link

Add message_type field to the schema attribute validator #46

Closed mantoine96 closed 4 years ago

mantoine96 commented 4 years ago

After updating to the latest release (v1.4.1), we still got the same errors we had in #43

After investigating, I realized that I had forgotten to had the message_type field to the keys slice in resourceAlarmCreate and resourceAlarmUpdate, effectively leaving the message_type out of our creation POST/PUT requests.

Additionally, I added the message_type field to the validateSchemaAttribute method.

After building my changes, I was able to successfully apply my changes.

@tbroden84 FYI

tbroden84 commented 4 years ago

Thanks, true that. Currently doing some testing but will make a new release when I finish.

mantoine96 commented 4 years ago

Thank you again @tbroden84!

tbroden84 commented 4 years ago

Have now release a new version 1.5.0 with your updates. Also tried them out and worked for me to add a queue alarm.