search

cloudanswers / salesforce_marketing_calendar

Marketing Calendar for Salesforce.com
4 stars 3 forks source link

Upgrade JQuery in Marketing Calendar #14

Closed thepaulfox closed 7 months ago

thepaulfox commented 1 year ago

Security review failed because of the old version of JQuery. Need to get it updated and see if there are any other plugins that need to be updated.

jagmohansingh commented 1 year ago

@thepaulfox Here is the updated package with new latest jquery libraries: https://login.salesforce.com/packaging/installPackage.apexp?p0=04t1T000000EzMP&isdtp=p1

thepaulfox commented 1 year ago

Requires full test of app.

iancccosgrove commented 1 year ago

@jagmohansingh @thepaulfox

I recorded a video showing the behavior. Filters on "Campaign Type" function correctly, however, the campaigns themselves do not display properly on the calendar and I am also unable to query campaigns via the "Parent Campaign" dropdown.

https://watch.screencastify.com/v/NLZjKGxIrWw7YYY8dLqv

jagmohansingh commented 1 year ago

@iancccosgrove Can you please make the Parent and Child campaign both are active?

jagmohansingh commented 1 year ago

I have tested this in my dev org and seems to be working as expected.

iancccosgrove commented 1 year ago

I have retested and can confirm that it works as expected.

thepaulfox commented 11 months ago

@jagmohansingh I'm not getting the calendar to load in the latest GA package. This is the error I'm seeing in the console: Image https://login.salesforce.com/packaging/installPackage.apexp?p0=04tHs0000015sDP&isdtp=p1

thepaulfox commented 11 months ago

@thepaulfox to create new package and test

thepaulfox commented 11 months ago

Issues reported with this version:

  1. Campaigns were showing up with the start date a day later than expected.
  2. One customer reported a JS issue image

1.24 created with reverted code. Need to work on fixing these issues and getting a new version out.

jagmohansingh commented 10 months ago

@thepaulfox I have fixed the issue with start date. Now, both start and end dates are correct across multiple timezones. You can review this in packaging org.

I haven't been able to replicate the other issue.

thepaulfox commented 10 months ago

Try bundling or namespacing Jquery

thepaulfox commented 10 months ago

@thepaulfox to get login to sandbox for illinois treasurer if possible

thepaulfox commented 10 months ago

Sent a message to jrobinson the Illinois treasurer. https://app.intercom.com/a/inbox/g8vi6v4i/inbox/conversation/32224700039909

thepaulfox commented 10 months ago

@jagmohansingh To try bundling Jquery

jagmohansingh commented 9 months ago

@thepaulfox I put together a static version which is built using webpack: https://ca-marketing-calendar-dev-ed--c.vf.force.com/apex/NewCalendar

It is in the test org. Please review.

Next, we will need to migrate all the logic to this page.

thepaulfox commented 9 months ago

@jagmohansingh I like the look. I like the view options (month, week, day, list). Is this the same calendar library or a new one? Is there anything else you'd like me to take a look at?

This calendar, with the ability to filter on any campaign field, and the on-click modals working again would be very useful.