Remove special handling of post/put in _make_request.

cloudant-labs / cloudant-python

Asynchronous Cloudant / CouchDB interface for Python

http://cloudant-labs.github.io/cloudant-python/

37 stars 17 forks source link

Remove special handling of post/put in _make_request. #46

Closed mgmarino closed 10 years ago

mgmarino commented 10 years ago

Addresses cloudant-labs/cloudant-python#45

garbados commented 10 years ago

Hey! Happy to merge this, once the test suite passes :)

mgmarino commented 10 years ago

Hey, yeah, I just saw recently that it was failing the build tests. I will fix those and come back to you. Thanks!

garbados commented 10 years ago

Wahoo! I look forward to it :)

coveralls commented 10 years ago

Changes Unknown when pulling ef8f3f4010839a13aa657d9bf707e19c16e4d01c on mgmarino:fix_view_post into \ on cloudant-labs:master**.

mgmarino commented 10 years ago

Hi!

Ok, I think this solution is better, or at least much "lighter" and doesn't break previous functionality. Now, if the user sends both 'data' and 'params' to a 'put'/'post' request,_make_request simply assumes the user knows what she's doing and doesn't overwrite 'data'. I've also added a unit test for post-to-view (multi-key fetch).

garbados commented 10 years ago

LGTM! Thanks :D