Error with vcapServiceName in TypeScript

cloudant / nodejs-cloudant

Cloudant Node.js client library

Apache License 2.0

255 stars 90 forks source link

Error with vcapServiceName in TypeScript #365

Closed Save92 closed 5 years ago

Save92 commented 5 years ago

Bug Description

1. Steps to reproduce and the simplest code sample possible to demonstrate the issue

2. What you expected to happen

Create Cloudant service with the vcap_services

3. What actually happened

Argument of type '{ vcapServiceName: string; vcapServices: any; }' is not assignable to parameter of type 'string | Configuration'.

I think the vcapServiceName is missing in the cloudant Configuration parameters, so in TypeScript it's crashing

Environment details

ricellis commented 5 years ago

Agreed, only the vcapInstanceName and vcapServices are currently listed in the TypeScript defs. @smithsz can you roll this into #359 along with the other broken TS things.

smithsz commented 5 years ago

Fixed in #369.