cloudant / nodejs-cloudant

Cloudant Node.js client library
Apache License 2.0
255 stars 90 forks source link

Don't add npm-cli-login as a dependency in the published package #378

Closed madbence closed 5 years ago

madbence commented 5 years ago

Checklist

Description

Running npm install @cloudant/cloudant should not install dependencies that are not listed in package.json. Starting from npm@5, npm install foo by default saves foo as a dependency, npm-cli-login is saved in the package.json right before jenkins publishes the package.

you can verify this with npm view @cloudant/cloudant dependencies.

Approach

I've added --no-save, so npm-cli-login won't be saved in dependencies.

Schema & API Changes

No change

Security and Privacy

No change

Testing

N/A

Monitoring and Logging

No change