343 fix pylint 1.8.1 - Githubissues

cloudant / python-cloudant

A Python library for Cloudant and CouchDB

Apache License 2.0

163 stars 55 forks source link

343 fix pylint 1.8.1 #346

Closed emlaver closed 6 years ago

emlaver commented 6 years ago

What

Fix pylint issues and have code rated 10/10.

How

Disabled ‘keyword-arg-before-vararg’ pylint warning
removed return statement to fix pylint ’inconsistent-return-statements’

Testing

CI passing, lint version changes only.

Issues

fixes #343

For discussion: I’ve disabled warnings for ‘keyword-arg-before-vararg’. If we want to enable this warning, it would require re-working the error module and making changes to all exception calls.

ricellis commented 6 years ago

I think this PR should revert the pylint version pinning as well

emlaver commented 6 years ago

@ricellis All tests passing now with the latest commit f7597fb.