cloudant / python-cloudant

A Python library for Cloudant and CouchDB

Apache License 2.0

163 stars 55 forks source link

Removed user and pass from URL when not using basic auth #383

Closed emlaver closed 6 years ago

emlaver commented 6 years ago

Thanks for your hard work, please ensure all items are complete before opening.

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
[x] You have added tests for any code changes
[x] You have updated the CHANGES.md
[x] You have completed the PR template below:

What

Shortened the length of client URLs by removing the username and password.

How

Parsed the hostname and port of the URL using url_parse.

Testing

Added CouchDB and Cloudant tests to assert that creds were removed from URL

Issues

363

For reviewers:

Should we keep the logic to set username and password if user and auth_token are empty?