search

cloudant / python-cloudant

A Python library for Cloudant and CouchDB
Apache License 2.0
163 stars 55 forks source link

Cannot set filter parameters in changes() call #402

Closed mythsmith closed 6 years ago

mythsmith commented 6 years ago

The Feed._validate method makes it impossible to pass arbitrary query parameters to a _changes filter design document when calling CouchDatabase.changes(). https://github.com/cloudant/python-cloudant/blob/4435d84f24dd3563e4abd2929e2953eeba0d5b89/src/cloudant/feed.py#L114 If the key is not in arg_types, it should assume it is a custom parameter directed at the filter and hope. Maybe just check if it is an int, float, or str, as these are the only supported types for the query.

I suppose the same holds for Cloudant._db_updates().

rajinib commented 6 years ago

@mythsmith Thanks for bringing this to our attention. We will add this to our backlog and prioritize as needed.