cloudant / python-cloudant

A Python library for Cloudant and CouchDB
Apache License 2.0
163 stars 55 forks source link

Fixup unit tests Broken by Couch3 #457

Closed James1912 closed 4 years ago

James1912 commented 4 years ago

Checklist

Description

The most recent RC builds include metadata changes that mean disk_size has been removed. The test will now pop disk_size if it exists. There is also changes to the format of warnings.

Approach

Fixed up the test DesignDocumentTests::test_get_info - the most recent RC builds include meta data changes that mean disk_size has been removed. The test will now pop disk_size if it exists.

Fixed up the test CloudantIndexExceptionTests::test_index_usage_via_query - the most recent RC builds include warning message format changes - instead of responding with no matching index found the database responds with No matching index found. The test will now .lower() the warning message.

Schema & API Changes

No change

Security and Privacy

No change

Testing

Run the tests against the latest RC build and assert they pass.

Monitoring and Logging

No change

mojito317 commented 4 years ago

Hi @James1912!

I have rerun the job belonging to this branch and it looks like you have missed to make conditional the following assertions about the disk_size:

James1912 commented 4 years ago

Hiya @mojito317 thanks for taking a look at this. That test is not failing with the latest RC I am testing - it seems that _search_disk_size has been left with the disk_size key.

What cloudant instance is the CI hitting up out of interest?