Make `create_query_index` always supply `partitioned` - Githubissues

cloudant / python-cloudant

A Python library for Cloudant and CouchDB

Apache License 2.0

163 stars 55 forks source link

Make `create_query_index` always supply `partitioned` #470

Closed bessbd closed 4 years ago

bessbd commented 4 years ago

Checklist

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
[x] Added tests for code changes or test/build only changes
[x] Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
[x] Completed the PR template below:

Description

The issue is described in #468 . create_query_index does not always supply partitioned which is always required by the service.

Approach

This PR changes the behavior that so that partitioned is now always present in the create_query_index requests.

Schema & API Changes

~~- "No change"~~

EDIT: Two default False parameters have been changed to None. The users should not notice any difference.

Security and Privacy

"No change"
- Added new test case
Monitoring and Logging
- "No change"
This fixes #468

bessbd commented 4 years ago

Thank you for the review, @ricellis ! I'm about to merge this once CI passes.