DeprecationWarning fix for method_whitelist

cloudant / python-cloudant

A Python library for Cloudant and CouchDB

Apache License 2.0

163 stars 55 forks source link

DeprecationWarning fix for method_whitelist #497

Closed app63 closed 2 years ago

app63 commented 3 years ago

FIX: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead

Checklist

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
[x] Added tests for code changes or test/build only changes
[x] Updated the change log file (CHANGES.md) or test/build only changes
[x] Completed the PR template below:

Description

DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead

Approach

## Schema & API Changes

Security and Privacy

Testing

Monitoring and Logging

ricellis commented 3 years ago

Thanks for this. Since our urllib3 dependency version is transitive via requests I think we need to wait for them to move their minimum to 1.26.0 before we can accept this change, at which point we'd also need to update our requests minimum version to match.

Otherwise we risk using allowed_methods with a version of urllib3 that doesn't support it. We could specify a urllib3 version here, but I'm reluctant to add a constraint that could get out of step with requests.

ricellis commented 2 years ago

Closing; requests haven't yet updated to a sufficiently recent version of urllib3 and this library is now EOL.