Remove assertion from test_get_feed_descending - Githubissues

cloudant / python-cloudant

A Python library for Cloudant and CouchDB

Apache License 2.0

163 stars 55 forks source link

Remove assertion from test_get_feed_descending #510

Closed mojito317 closed 2 years ago

mojito317 commented 2 years ago

Checklist

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
[x] Added tests for code changes or test/build only changes
[x] Updated the change log file (CHANGES.md) or test/build only changes
[x] Completed the PR template below:

Description

This assertion removal fixes failed pipeline. Comparing seq lengths is not grounded in any contract of the API.

Approach

I removed the assertion regarding seq length comparison.

Schema & API Changes

"No change"

Security and Privacy

"No change"

Testing

Modified existing tests because comparing seq lengths is not grounded in any contract of the API.

Monitoring and Logging

"No change"

mojito317 commented 2 years ago

Thanks for the reviews @ricellis and @eiri! I am about to merge this!