cloudaper / epics-action

Automatically update task list when referenced issue is closed
58 stars 9 forks source link

Don't throw error when issue is deleted #6

Closed krystof-k closed 3 years ago

renestefancic2 commented 3 years ago

Any ETA on this?

krystof-k commented 3 years ago

I'll try to push it forward soon!

renestefancic2 commented 3 years ago

Thank you! Appreciate your work.

krystof-k commented 3 years ago

Done. However it will not check the issue mentioned in the epic – it would require to completely rework how the action works and I'm not sure whether it would even be desired behavior.

renestefancic2 commented 3 years ago

I keep getting the error

Error: TypeError: Cannot read property 'number' of undefined
Error: Cannot read property 'number' of undefined

Which I assume is thrown when issues are deleted. In my case, both the epic (parent) and issues referenced in the epic were deleted.

krystof-k commented 3 years ago

I see – it probably hasn't fixed when epic is deleted. Reopening and I'll look further into that.

krystof-k commented 3 years ago

I wasn't able to replicate it. It works fine when both the issue or the epic is deleted.

renestefancic2 commented 3 years ago

I was also not able to replicate it after further testing.

Interestingly enough, it's now working properly and is no longer throwing any errors.

This can probably be closed.