search

cloudbase / cloudbase-init

Cross-platform instance initialization
http://openstack.org
Apache License 2.0
427 stars 150 forks source link

Enable static network configuration via vmware guestinfo #2 #107

Open sidaf opened 1 year ago

sidaf commented 1 year ago

Based on pull request #83 opened on Nov 22, 2021 by kimbernator.

Apply fixes for "pep8: H306: imports not in alphabetical order" and "pep8: W292 no newline at end of file", which hopefully should make this mergeable.

sidaf commented 1 year ago

Also submitted patch to opendev: https://review.opendev.org/c/x/cloudbase-init/+/829757/comments/2f77aa55_db8f1d1e

nwmcsween commented 1 year ago

Is there anything needed to push this past the finish line?

pbesret commented 10 months ago

Could someone merge if this PR is ok ?

ader1990 commented 10 months ago

@pbesret I gave it a recheck on the opendev board, as we merged support for the 3.11 Python. Let's continue this discussion on opendev.

Thanks!

FlorianLaunay commented 9 months ago

Hi folks. Great job! This feature will finally bring VMware datasource to its expected level. Can we expect a merge soon?

FlorianLaunay commented 6 months ago

Hi @ader1990. This feature will be awesome! Can we expect a merge soon?

FlorianLaunay commented 4 days ago

Hi @ader1990 Could you please close this PR ? This feature was finally brought by f0fe66b in release 1.1.5.