search

cloudbase / cloudbase-init

Cross-platform instance initialization
http://openstack.org
Apache License 2.0
427 stars 150 forks source link

Feature/fix dns setup for Proxmox #116

Open vladyslavpro01 opened 1 year ago

vladyslavpro01 commented 1 year ago

this fixes DNS setup for Proxmox related to https://github.com/cloudbase/cloudbase-init/issues/56

I've tested the _set_interface_dns it was not working, that's why I've changed it to a native os command call

ader1990 commented 1 year ago

Hello,

We are currently using opendev for patches: https://review.opendev.org/q/project:x/cloudbase-init

How to create an account and contribute to: https://docs.openstack.org/contributors/common/setup-gerrit.html

Thank you, Adrian Vladu.

Puben commented 1 year ago

Hi - This relevant feature/fix does not seem to be added to OpenDev. Id like to contribute but perhaps not my place to take the edits proposed by @vladyslavpro01 and add it to OpenDev.

ader1990 commented 7 months ago

Hello @Puben @vladyslavpro01, the first commit that changes the dns regex can be merged if a small patch is added to opendev. The second commit seems to be breaking the backwards compatibility -- why is the second commit needed?

Thank you.