search

cloudbase / cloudbase-init

Cross-platform instance initialization
http://openstack.org
Apache License 2.0
408 stars 149 forks source link

cloudbase-init doesn't support cidata label #135

Open holmanb opened 3 months ago

holmanb commented 3 months ago

An attempt was made to correct this, however the value passed through to this function is still 'config-2'

https://github.com/cloudbase/cloudbase-init/blob/4bb6895f115c8cb20ee9be37d5facc84243d0113/cloudbaseinit/metadata/services/configdrive.py#L30

We recently got a request to customize cloud-utils due to this.

holmanb commented 3 months ago

I just filed a PR for this.

Aside: Gerrit seems to be preventing contributions. I only went through with it because I plan to submit a PR against Nova soon, which also uses it. Learning a new workflow for one-off contributions like this is painful.

ader1990 commented 3 months ago

I just filed a PR for this.

Aside: Gerrit seems to be preventing contributions. I only went through with it because I plan to submit a PR against Nova soon, which also uses it. Learning a new workflow for one-off contributions like this is painful.

Hello, thank you for the PR. I know that the Gerrit is not a straightforward experience, we are planning to move to Github in the future. Will update the Gerrit review page with my comments on the fix.

Thank you!

holmanb commented 3 months ago

Thanks for the response @ader1990!

It looks like commit 9b17eaf1d4 hasn't been released yet, which probably explains why the user has to use the config-2 label.

When is the next cloudbase-init release expected? I'd like to let the user know when they can expect this feature will be available.

Since this is an upcoming feature in cloudbase, I don't think that adding a short-lived workaround to cloud-utils makes sense, so I just rejected the proposal to add arbitrary label names to cloud-utils.

Hello, thank you for the PR. I know that the Gerrit is not a straightforward experience, we are planning to move to Github in the future. Will update the Gerrit review page with my comments on the fix.

Thank you!

+1 Great! :)

ader1990 commented 3 months ago

Hello, we have a few small PR backlog to merge first before a new release, but it should happen in the next month or so (already one year since the last release). I will update this issue once a new stable version has been released.

Thank you, Adrian.