Closed BirknerAlex closed 3 years ago
Hello,
Thank you for the PR.
Currently, we still use https://review.opendev.org/ for development, while Github is used as a read only mirror and for issue tracking. Cloudbase-init is a project under the OpenStack umbrella, so if you have contributed to one of the OpenStack projects, the workflow is the same - you need an opendev/launchpad account and use git review
for the patches.
These are the open patches for cloudbase-init on opendev: https://review.opendev.org/#/q/status:open+project:x/cloudbase-init
As for the building it, we have the installer code here: https://github.com/cloudbase/cloudbase-init-installer You can leverage the Github actions to build the MSI for you with no hassle whatsoever, with a fee installer changes. You can fork my installer repo https://github.com/ader1990/cloudbase-init-installer-1/tree/nocloud_v2_net_support and just change the remote / branch from the file https://github.com/ader1990/cloudbase-init-installer-1/blob/nocloud_v2_net_support/.github/workflows/build_cbsinit.yml#L12 . If you have the Github Actions enabled for that repo, after the change, a zipped installer will be created for the actions run.
On the code itself, can you share more information in the commit message and the docs part: what is HiBee cloud and if you could put a link there to the documentation of that metadata service itself.
That Gitlab actions config is awesome, I will try it. I close this PR now to move it go opendev.org. I guess I also need to sign a CLA with OpenStack before. I will try to bring up everything tomorrow.
Regarding docs: HiBee isn't public yet, it's a provisioning system which is used by some companies internally, so there are no public docs available at the moment.
I would love to add it to Cloudbase-Init before the docs are available. If that is possible I would create a second PR which adds documentation afterwards, I don't know when docs are publicly available (but they will).
This pull-requests adds a new provider to Cloudbase-Init.
But before merging it I would love to receive a .msi Download package including my branch to test it on several nodes.
I tried to build my own msi package but I clearly failed, but I even can't find any information how to build the cloudbase-init project (needed Visual Studio version, python version, other needed tools, ...).
I used a Windows 2019 server machine with following tools installed:
But it failed with
Maybe someone could help me with that or link me to a build documentation for further testing since I am not very familiar with developing software on Windows.
Thank you.