Cloud-config user 'inactive' option can't be set due to 'no_create_home' bug

[nullptr0000]

If cloud-config userdata tries to configure a user with the 'inactive' option set to True, the creation of that user fails with the exception "_The user is required to be enabled if public_keys or createhome are set".

This is due to the undocumented option '_no_createhome' also having to be set to True for the 'inactive' option to work.

Unfortunately this isn't possible as an error in cloudbaseinit/plugins/common/userdataplugins/cloudconfigplugins/users.py (line 118) means that the code checks the value of '_no_createhome ' (with an extra space added to the end) not the proper option '_no_createhome'. This means the option cannot be set by the userdata and always remains at the default value of False, which in turn makes it impossible to use the 'inactive' option.

Replacing the incorrect item.get('no_create_home ', False)) with item.get('no_create_home', False)) makes the code function as expected.

Extra comments:

• The exception message refers to the internal variable names from the local code, not to the actual configuration item names that need to be set. This is confusing for the end user / wrong!
• The '_no_createhome' option is completely undocumented, including the dependency with 'inactive'.
• The test for this function only checks the failure case of the values being misaligned so doesn't detect this bug as the code always fails. There are no proper validation tests for the 'inactive' or '_no_createhome' settings working.

[jf]

thank you for putting in the work to diagnose this, @nullptr0000 ! I've been thinking no_create_home was a working thing until I actually looked and saw that the home directory was still being created for my users...