search

cloudbase / cloudbase-init

Cross-platform instance initialization
http://openstack.org
Apache License 2.0
414 stars 150 forks source link

VMwareGuestInfoService is not implementing static network configuration #78

Open janitha opened 2 years ago

janitha commented 2 years ago

VMwareGuestInfoService is not implementing the static network configuration at the moment (I haven't tried this to verify it, but looking at the source, VMwareGuestInfoService is not implementing get_network_details nor get_network_details_v2)

Before I started working on a PR, I wanted to know if there was a specific reason this wasn't included? cc @rgl Thanks!

akutz commented 2 years ago

cc @akutz

rgl commented 2 years ago

At the time I didn't known about it. Funnily enough, today I was looking for it! :-)

@janitha, do you want to work on it? I can do it otherwise.

I think its a matter of returning the metadata network key value. Which is aligned with https://github.com/canonical/cloud-init/blame/8b4a9bc7b81e61943af873bad92e2133f8275b0b/doc/rtd/topics/datasources/vmware.rst#L219-L225.

janitha commented 2 years ago

@rgl I haven't started on this yet and a bit tied up with other work, you can take this on, much appreciated!

twalcari commented 2 years ago

@ader1990 Can this PR be merged please?

FlorianLaunay commented 7 months ago

Feature will now be provided by #107