search

cloudbase / cloudbase-init

Cross-platform instance initialization
http://openstack.org
Apache License 2.0
414 stars 150 forks source link

enable static network configuration via vmware guestinfo #83

Open kimbernator opened 2 years ago

kimbernator commented 2 years ago

Resolves https://github.com/cloudbase/cloudbase-init/issues/78

This enables static networking configuration in the vmware guestinfo metadata source. I basically just have it parse the network data using the nocloud network config v1 parser since they follow the same spec.

I'm a bit green to this codebase so please let me know if there's more I need to add for this to have the intended effect.

doumhfr commented 2 years ago

is this patch working ?

I try to do the modification but I've got an error : Cannot import name 'NoCloudNetworkConfigV1Parser'

ader1990 commented 2 years ago

is this patch working ?

I try to do the modification but I've got an error : Cannot import name 'NoCloudNetworkConfigV1Parser'

Hello,

Please make sure that you have the latest cloudbase-init version installed / cloned before trying to patch the code with this commit.

We are currently using OpenStack's review workflow for accepting patches, see this workflow: https://github.com/cloudbase/cloudbase-init/issues/62#issuecomment-776076041

Thank you, Adrian

twalcari commented 2 years ago

Hi Adrian,

Thank you for commenting on this issue. Would it be possible to add the information about this OpenStack review workflow that you have adopted somewhere visible in this repository? ie. in the README or by mentioning it in the pull request template ? I would already have followed all steps in this workflow months ago if I had known about it.

kimbernator commented 2 years ago

The import should be fixed now. The codebase is on the current version.

kimbernator commented 2 years ago

I have submitted the patch as requested. As @twalcari said, this should be documented. Frustrating that it took two and a half months to be notified of this.

jaymzmac commented 2 years ago

@kimbernator did you see there were some minor lint issues that need fixing before your patch can be merged? https://review.opendev.org/c/x/cloudbase-init/+/829757

PrimordialLight commented 2 years ago

@kimbernator you able to clean up those two small lint issues? Been wanting to use this patch for awhile

kimbernator commented 1 year ago

I no longer work for the employer whose email I used to log into opendev.org, and consequently I don't have a personal or professional need for this change. If someone else wants to make this contribution, they are free to do so.

FlorianLaunay commented 7 months ago

Feature will now be provided by #107 . Could you please close this one ?