cloudbase / garm

GitHub Actions Runner Manager
Apache License 2.0
136 stars 26 forks source link

fix: remove unnecessary github api call #255

Closed bavarianbidi closed 5 months ago

bavarianbidi commented 5 months ago

There are only a few cases, where we get a job information from github where the runner name is not set.

For all this cases we do not need to check github API at all because these jobs are never ever get scheduled to a runner:

job.Action is:

gabriel-samfira commented 5 months ago

Could you add a check here:

https://github.com/cloudbase/garm/blob/02ff74bfe89e85bb0d9a689a99f2ea3169d113d8/runner/pool/pool.go#L212

For the runner name. And just log that there was no runner assigned and just return nil.

Saves us some unnecessary db queries and log spam