Closed Hdom closed 1 month ago
Hello, I've noticed that GitHub's runner software tag validation is case insensitive but the login in findPoolByTags seems to be case sensitive.
https://github.com/cloudbase/garm/blob/main/database/sql/pools.go#L187
Our current workaround includes lowercasing input tags and lowercasing stored tags in the comparison:
for i, tag := range tags { tags[i] = strings.ToLower(tag) } where := fmt.Sprintf("lower(tags.name) in ? and %s = ? and enabled = true", fieldName)
Do you think we could get this included?
We can add a COLLATE NOCASE in that WHERE tags.name IN clause. Adding a PR soon.
COLLATE NOCASE
WHERE tags.name IN
can you give this a try: https://github.com/cloudbase/garm/pull/296
Hello, I've noticed that GitHub's runner software tag validation is case insensitive but the login in findPoolByTags seems to be case sensitive.
https://github.com/cloudbase/garm/blob/main/database/sql/pools.go#L187
Our current workaround includes lowercasing input tags and lowercasing stored tags in the comparison:
Do you think we could get this included?