Missing --no-default--labels on windows cloudconfig template in common

cloudbase / garm

GitHub Actions Runner Manager

Apache License 2.0

132 stars 25 forks source link

Missing --no-default--labels on windows cloudconfig template in common #308

Closed Hdom closed 20 hours ago

Hdom commented 1 day ago

Hello, seems that when the no-default-labels feature was introduced it was only included in the linux template: https://github.com/cloudbase/garm-provider-common/commit/b658eb8b8358402e811fb4327bbeafe0e011f7db

Should this be included in the windows template?

gabriel-samfira commented 1 day ago

Yes, it should. We should add integration tests for windows as well, and make sure we test for this as well. Will add the flag in the windows userdata asap.