cloudbase / windows-imaging-tools

Tools to automate the creation of a Windows image for OpenStack, supporting KVM, Hyper-V, ESXi and more.
Apache License 2.0
675 stars 227 forks source link

Integrating W10 updates never completes #254

Closed danboid closed 4 years ago

danboid commented 5 years ago

I have got the openstack Windows imaging scripts to work with W10 Enterprise but only without integratng Windows updates. If I choose to integrate Windows updates (which is what we would prefer to do), the script does 2 or 3 rounds successful rounds of updates that take quite a while and then the 3rd or 4th round of updates (after the 1804 update) seems to only consist of one small update that downloads, installs and reboots and does this on loop.

The installer continues to download and re-install this update on loop and so sysprep/the imaging scripts never complete. Because this problematic update is only small, it installs too quickly for me to see what the reference code of the update is.

I will try to get a newer ISO to see if starting from a newer base works around this issue.

ader1990 commented 5 years ago

There is a line where you can add blacklist updates that fail to install, in case you find the offending one: https://github.com/cloudbase/windows-openstack-imaging-tools/blob/master/UnattendResources/Logon.ps1#L124

danboid commented 5 years ago

I'm not sure how long it took for the final update to apply but the boot loop did come to end eventually. It must've done at least 20 download, install and reboot cycles before I walked away and left it for a couple of hours. When Ireturned the VM was on the Windows login screen.

Still, I had to manually power off the VM for sysprep to finish (I'm presuming it did run properly?) and to finalise the image.

danboid commented 5 years ago

I enabled "purge_updates" but I don't think that worked as the resultant image was about 25 GB uncompressed.

danboid commented 5 years ago

Re-opened this because after several attempts I have failed to create a working Windows 10 Enterprise image with integrated updates. I cannot get a newer version of the w10 ent. ISO than the one I have currently so that isn't an option for me.

Have you tested update integration recently @ader1990?, specifically with W10 Enterprise?

ader1990 commented 5 years ago

@danboid can you please run again with this PR? https://github.com/cloudbase/windows-openstack-imaging-tools/pull/292

I have added more logging from the live VM and it will be useful to debug the root cause.

I will try to create in my env an enterprise image and will come back with results.

Thank you, Adrian Vladu

ader1990 commented 5 years ago

@danboid I tried with an older version of Windows 10 enterprise ISO (1703) and it failed for me too. I will push a fix later on when I get all the pieces on why it failed.

danboid commented 5 years ago

Thanks Adrian!

ader1990 commented 5 years ago

@danboid can you try with this PR? https://github.com/cloudbase/windows-openstack-imaging-tools/pull/293

danboid commented 5 years ago

It won't be today now but hopefully I'll have time tomorrow.

ader1990 commented 5 years ago

@danboid It worked for me with this PR, let me know when you finish and we can merge it. the image generation took a little over 3 hours .

ader1990 commented 4 years ago

Closing the issue, as there is no activity in the last months and the issue should have been fixed by PR #293