Add support for Windows Server 2019

cloudbase / windows-imaging-tools

Tools to automate the creation of a Windows image for OpenStack, supporting KVM, Hyper-V, ESXi and more.

Apache License 2.0

675 stars 227 forks source link

Add support for Windows Server 2019 #268

Closed felfert closed 5 years ago

felfert commented 5 years ago

This PR adds support for Windows Server 2019, using latest virtio-win-0.1.171

While testing, I also found out, that the fallback to win2k12r2 drivers in WinImageBuilder.ps1, line 697 is probably a bad idea, because no error or warning is printed, but a non-functional image is generated. This should be replaced by fatal error, clearly stating that the appropriate drivers are missing.

ader1990 commented 5 years ago

This PR needs a rebase. I will let you know once I give it a run on my env if there are any issues.

felfert commented 5 years ago

Yes, I created it befoe you committed your vhdx compression stuff last week. It is actually pretty trivial: It adds a third criteria (the buildnumber) to the map used for determining the driver-path on the virtio iso. If the buildnumber in the map is non-zero, it is used to distinguish between 2k16 and 2k19.

About the fallback to win2k12r2 drivers: I ran into this when I accidently used an older virtio iso which did not contain the 2k19 drivers.

felfert commented 5 years ago

Rebased it for you

AppVeyorBot commented 5 years ago

:white_check_mark: Build windows-openstack-imaging-tools 1.0.61 completed (commit https://github.com/cloudbase/windows-openstack-imaging-tools/commit/f15b231279 by @felfert)

felfert commented 5 years ago

Ooops - that went totally wrong. Closing this PR and create a new clean PR