search

cloudbase / windows-imaging-tools

Tools to automate the creation of a Windows image for OpenStack, supporting KVM, Hyper-V, ESXi and more.
Apache License 2.0
675 stars 227 forks source link

driversBasePath is missing? #270

Closed Brardith closed 5 years ago

Brardith commented 5 years ago

Attempting to build with a modified create-windows-online-cloud-images.ps1, this is my error output:

Edit: I am running out of master branch, cloned on June 12 2019

New-WindowsCloudImage : A parameter cannot be found that matches parameter name 'driversBasePath'.
At C:\Users\brardith\Documents\windows-openstack-imaging-tools\WinImageBuilder.psm1:1222 char:9
+         New-WindowsCloudImage -ConfigFilePath $offlineConfigFilePath
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [New-WindowsCloudImage], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,New-WindowsCloudImage
ilenghel commented 5 years ago

Hello,

I am guessing you want to add VirtIO drivers to you image. This can be achieved in two ways:

  1. Using virtio_iso_path parameter, and giving it the path to a local ISO of the VirtIO drivers.
  2. Using virtio_base_path, and giving it the path to a directory that contains the VirtIO drivers. In this case the directory can be the drive letter of a mounted ISO.

The New-WindowsOnlineImage function will detect if you specified one or the other and will use the appropriate method of adding the drivers to your image.

If this doesn't help, please share your modified create-windows-online-cloud-images.ps1 and we can debug it further from there.

ilenghel commented 5 years ago

Seems like this was caused by an incorrect parameter name on our side. Please use the latest code and it should work now.

Thank you for reporting this.

ader1990 commented 5 years ago

Fix merged, @Brardith can you check if it works now in your setup? Thank you.

Brardith commented 5 years ago

@ader1990 I grabbed the code from the PR yesterday and got it to work offline. Online I've got something wrong with my external vswitch, but that's all my fault! I think it's safe to say this specific issue is resolved.

ader1990 commented 5 years ago

@Brardith glad it all worked out!