Closed hoppla20 closed 4 months ago
Hello, thank you for the fix. PowerShell is sometimes really picky on the one item array, can you confirm that both cases work: with one feature and two comma separated features? Thanks.
I will test both cases and report back
So I have not tested extra_feature
with a single feature, but found another interessting "bug":
When I set extra_features="Feature-1,Feature-2"
it works, but extra_features=Feature-1,Feature-2
does not work. Do you have an idea why?
I just started getting into PowerShell, I had a quick look, but didn't find the cause of this behaviour
I have tried to reproduce the behaviour, but could not. What is the output of $PSVersionTable
in your Powershell?
This is the output of echo $PSVersionTable
:
Name Value
---- -----
PSVersion 5.1.17763.2090
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.17763.2090
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
I will try all cases (multiple features with and without quotes, single feature) again tomorrow. The environment I'm testing in is not the fastest, so each build takes forever...
Thank you for helping!
This PR is good to merge, as long as we document the good behaviour/bad behaviour in the Config.psm1. Can you elaborate on what the failure is if there are no double quotes?
Test with
[DEFAULT]
extra_features="Microsoft-Hyper-V,Containers"
Result: Build successfully
Tests without quotes and with only a single feature are also comming as soon as they are finished
Test with
[DEFAULT]
extra_features=Microsoft-Hyper-V,Containers
Same config.ini, only removed quotes.
So the problem I had yesterday was probably due to some other configuration change I made
So the problem I had yesterday was probably due to some other configuration change I made
Then it is all good for merge?
I see this error Could not retrieve VM runtime logs
-> but we can create a new issue for this problem.
I currently running the tests with extra_features=Micrsoft-Hyper-V
(only a single feature). When this build finishes successfully I would say it's ready to merge :+1:
Test with
[DEFAULT]
extra_features=Microsoft-Hyper-V
So yeah, works for all cases, can be merged :)
Fixes #388