search

cloudbase / wnbd

Windows Ceph RBD NBD driver
GNU Lesser General Public License v2.1
58 stars 26 forks source link

Code analysis #18

Closed aserdean closed 4 years ago

aserdean commented 4 years ago

This PR addresses code analysis warnings found in driver project.

Adds a new configuration called Analysis so the Microsoft code analyzer is ran, with the default rule set, when building the project.

Also update appveyor matrix so we can see potential defects.

A sample output can be viewed here: https://ci.appveyor.com/project/aserdean/wnbd-1/build/job/f382y7rx6ygidm91#L251

petrutlucian94 commented 4 years ago

Wouldn't it be better to just enable <RunCodeAnalysis>true</RunCodeAnalysis> for the existing configurations (Release/Debug)?

aserdean commented 4 years ago

We could, but it greatly increases build times (3 times - https://ci.appveyor.com/project/aserdean/wnbd-1/builds/35215661), hence the new configuration.

One minute and a half isn't that bad though.

petrutlucian94 commented 4 years ago

Makes sense, let's keep it as a separate build configuration then.