cloudbase / wnbd

Windows Ceph RBD NBD driver
GNU Lesser General Public License v2.1
58 stars 26 forks source link

driver: avoid vpd id page without actual identifiers #78

Closed petrutlucian94 closed 1 year ago

petrutlucian94 commented 1 year ago

The NAA id is the only identifier that we expose through the vpd id page. It's optional and the issue is that if no NAA id was specified for the device, then we'll have a vpd id page with no identifiers.

This confuses Windows, which seems to assume that multiple disks have the same null identifier and assigns them the same disk number.

In order to avoid this issue, we won't expose the vpd id page unless we actually have a NAA id.

Note that we could use the serial as a vendor id. However, we'll only use the NAA ID mostly because of buffer size constraints.

Signed-off-by: Lucian Petrut lpetrut@cloudbasesolutions.com