cloudblue / django-cqrs

django-cqrs is an Django application, that implements CQRS data synchronization between several Django micro-services
https://django-cqrs.readthedocs.io/en/latest/
Apache License 2.0
122 stars 24 forks source link

Dead letters commands customer settings #48

Closed net-free closed 2 years ago

net-free commented 2 years ago

https://github.com/cloudblue/django-cqrs/pull/39#issuecomment-971441722

Hey,

I've found that this Pull Request is breaking cqrs_dead_letters retry command.

_get_consumer_settings used to return 2 arguments and with this change it start to return tuple of 3, which is breaking init_broker method in above mentioned command. Exact line:

queue_name, dead_letter_queue_name = RabbitMQTransportService.get_consumer_settings()

is raising ValueError: too many values to unpack (expected 2)

net-free commented 2 years ago

duplicate #49