cloudcaptainsh / cloudcaptain

Issue Tracker for CloudCaptain
13 stars 3 forks source link

Spring Boot 2.0 support #174

Closed binkley closed 6 years ago

binkley commented 7 years ago

While moving to Spring Boot 2.0.0.M1, I noticed boxfuse did not automatically see that the healthcheck endpoint moved:

I tried the -Dhealthcheck.path=/application/health flag when running mvn boxfuse:run ... as suggested in the documentation, but the sysprop seemed to be ignored. So perhaps I'm doing it wrong.

axelfontaine commented 7 years ago

Thanks for letting us know. We haven't started reviewing the changes made in Spring Boot 2.0 yet (GA is not planned until Q4 2017). Until we do so, you can indeed override the healthcheck path by setting a property. As you can see in the docs (https://boxfuse.com/docs/maven/run) the property is prefixed with boxfuse. in order to avoid collisions with other plugins.

So in your case this should be -Dboxfuse.healthcheck.path=/application/health.

Note that if you come across other differences please post them here too, so we can make sure we account for them when implementing our Spring Boot 2.0 support.

In the issue you referenced you mentioned Boxfuse not picking up the artifact with a qualifier. It is correct that by default Boxfuse only picks up the main artifact of the build. You can however override this by specifying the artifact you want in the boxfuse.payload property. See https://boxfuse.com/docs/maven/run#payload

Which bits in the Spring docs are you missing in our docs?

binkley commented 7 years ago

Cool. Setting boxfuse.healthcheck.path did the trick, thanks.

I did not test setting boxfuse.payload -- I eliminated the need for a renamed jar (for now) by disabling a different maven plugin which had been conflicting with Spring Boot. I'll look at that later and let you know.

adamzr commented 6 years ago

I'm having the same issue and I should note that Spring Boot 2 is already GA now. If I use a boxfuse.conf file what should the property name be that I need to set?

axelfontaine commented 6 years ago

@adamzr It's healthcheck.path . See the second column: https://boxfuse.com/docs/commandline/fuse#healthcheck.path

adamzr commented 6 years ago

I add healthcheck.path=/actuator/health to my boxfuse.conf and ran the run command again. It didn't fix it.

axelfontaine commented 6 years ago

Full support for Spring Boot 2 has now been rolled out in the latest client release along with full autodetection of the new configuration property names and support for the new defaults.