cloudchen / grunt-template-jasmine-requirejs

RequireJS template for grunt-contrib-jasmine task
111 stars 96 forks source link

requier.js and jQuery #20

Closed Zammy closed 11 years ago

Zammy commented 11 years ago

I am using the version of require.js comined with jQuery. It seems that it is not supported out of the box.

I am also wondering why requier.js is not used from my source files rather than use embedded one with the template? If I am using require.js it should be somewhere in my source.

It would be nice if reqire.js options could be loaded from one file.

I can possibly try to add those features, are you considering pull requests?

Zammy commented 11 years ago

I simply hacked the tamplate to include my require.js file.

cloudchen commented 11 years ago

It seems a reasonable reason to load your preferred requirejs version like plus jquery ones. Because I only have experience with using of standalone requirejs version plus jquery module, never tried you mentioned ones. But adding one more option for external main require.js file seems strange and confusing with version configuration item. If you have good implementation, just submit PR.

cloudchen commented 11 years ago

For external require.js options file, we definitely will support it soon. You can also check this fork out, it has already supported it. https://github.com/reinseth/grunt-template-jasmine-requirejs

Zammy commented 11 years ago

Isn't it reasonable to just configure where the require.js file is in the project? No need to drag it with the template?