cloudchen / grunt-template-jasmine-requirejs

RequireJS template for grunt-contrib-jasmine task
111 stars 96 forks source link

added src attribute to templateOptions object for custom requirejs html template #63

Closed iamchrismiller closed 10 years ago

iamchrismiller commented 10 years ago

I have added the ability to use a custom requirejs template via a src attribute in the templateOptions hash. I also updated the README and added a test to validate custom template was used. Let me know if you don't agree with the implementation and I can adjust it accordingly.

cloudchen commented 10 years ago

Hi Chris, Thanks for your PR. Though there's a question that why do you need another template? Because this template is an automated solution for testing Jasmine spec, and spec runner page is just an entry point for bootstrapping Jasmine and specs. All requirements of spec runner should be implemented in one place, there's no reasonable to make another place to do the same thing(bootstrapping) IMHO. Any thoughts?