search

cloudchen / grunt-template-jasmine-requirejs

RequireJS template for grunt-contrib-jasmine task
111 stars 97 forks source link

Lodash support 3+ #88 #89

Open mikeapr4 opened 8 years ago

mikeapr4 commented 8 years ago

Note: this is backwards compatible to pre-v3 versions also.

radum commented 8 years ago

Hey @mikeapr4

Might be better if we upgrade this to Grunt 1.0 also. Here is a PR that should handle all of it #90

mikeapr4 commented 8 years ago

Hi @radum , I see your PR and it makes sense to replace usage of grunt.util._ as it's deprecated anyway. I chose the least amount of change, but your PR looks good to me. However your dev Grunt dependency upgrade has triggered some NPM warnings which has caused the build to go red.

radum commented 8 years ago

Hi @mikepr4,. Yeah just saw them. Once I get back from holiday next week I will fix those also. And we can move it fwd.

Thanks a lot