search

cloudcomponents / cdk-constructs

A collection of higher-level reusable cdk constructs
MIT License
625 stars 104 forks source link

bug(cdk-blue-green-container-deployment): Healthcheck grace period is not working #125

Closed cao2504 closed 3 years ago

cao2504 commented 3 years ago

Hi, I've using this packages for months and it works really well, one of the recent patch introduced new properties to ecs service like healthcheck grace period which I find really helpful but it doesnt seem to work. I could see the property showed up in the cloud formation template but it was not applied to the service. This also not work even with default value as 60 seconds Eg: The property showed up in the template but not in the service image The value is 0 in the service image

cao2504 commented 3 years ago

ah found the culprit, there is a typo in the lamda https://github.com/cloudcomponents/cdk-constructs/blob/375ecd9eff5557636401f848d2b7685389e727a2/packages/cdk-blue-green-container-deployment/src/lambdas/ecs-service/index.ts#L48 this should be props.HealthCheckGracePeriod instead of props.HealthCheckGracePeriodSeconds