cloudcomponents / cdk-constructs

A collection of higher-level reusable cdk constructs
MIT License
625 stars 104 forks source link

feature request: allow different type of subnets #159

Open cao2504 opened 2 years ago

cao2504 commented 2 years ago

For the latestcdk v1 version, the default subnet type is set to Isolated instead of Private https://github.com/aws/aws-cdk/blob/master/packages/aws-cdk/lib/context-providers/vpcs.ts. When deploying the stack it will fail and complain about subnets are empty. Can we have a flexibility to choose which type of subnet to be passed in?

https://github.com/cloudcomponents/cdk-constructs/blob/28be2087009458aaa594aabe3d488dc3f4dd1815/packages/cdk-blue-green-container-deployment/src/ecs-service.ts#L138