cloudcomponents / cdk-constructs

A collection of higher-level reusable cdk constructs
MIT License
623 stars 101 forks source link

Update desired count behavior #194

Open rogperez opened 1 year ago

rogperez commented 1 year ago

Hello!

We've noticed that during a deployment, the DesiredCount will always end up being managed by CloudFormation due to it's presence in the template. We tried removing this using an escape hatch but that caused another issue with the way the scheduling strategy of REPLICA works. When you use REPLICA, you're required to pass in a desired count on create, but on update it can be omitted as it is already present on the ecs service itself. In this PR we simply removed the need for the DesiredCount to be in the generated CloudFormation template, and simply enforce it's default of 1 in the custom resource Create handler itself. This implementation will be flexible enough to still pass in a desired count whenever you please!

Best, Roger