cloudconvert / cloudconvert-dotnet

CloudConvert .NET SDK
Other
20 stars 15 forks source link

Computing signature - why ASCII and not JSON? #2

Closed cmeeren closed 3 years ago

cmeeren commented 3 years ago

In the code below, you use ASCII encoding for the webhook body. Isn't UTF8 encoding more correct? (The result is the same as long as the body does not contain any non-ASCII characters, but JSON bodies must be UTF8 according to the JSON spec, section 8.1).

https://github.com/cloudconvert/cloudconvert-dotnet/blob/0edc588ba7d8a7fc5fc557a71700a73f38adde70/CloudConvert.API/CloudConvertAPI.cs#L216-L220

josiasmontag commented 3 years ago

Fixed by version 1.0.1.