Replace ReadAsStringAsync with ReadAsStreamAsync - Githubissues

cloudconvert / cloudconvert-dotnet

CloudConvert .NET SDK

Other

20 stars 15 forks source link

Replace ReadAsStringAsync with ReadAsStreamAsync #7

Open Ggeorgi98 opened 3 years ago

Ggeorgi98 commented 3 years ago

The size of the HTTP responses can differ and we can get very huge responses. If we store them as a string, they can end up in the Large object heap which can lead to some performance issues most related to the memory. https://github.com/cloudconvert/cloudconvert-dotnet/blob/0edc588ba7d8a7fc5fc557a71700a73f38adde70/CloudConvert.API/RestHelper.cs#L27-L29 For reference:

'You're (probably still) using HttpClient wrong and it is destabilizing your software', Josef Ottosson - link - you can check the section with the benchmarks and see that ReadAsStreamAsync has performed better than ReadAsStringAsync.