search

cloudcreativity / laravel-json-api

JSON API (jsonapi.org) package for Laravel applications.
http://laravel-json-api.readthedocs.io/en/latest/
Apache License 2.0
780 stars 109 forks source link

Update abstract adapter stub #560

Closed daryledesilva closed 4 years ago

daryledesilva commented 4 years ago

fixes these errors on a freshly generated abstract adapter:

Declaration of App\JsonApi\Adapters\SearchResultAdapter::exists($resourceId) must be compatible with CloudCreativity\LaravelJsonApi\Contracts\Adapter\ResourceAdapterInterface::exists(string $resourceId): bool
Declaration of App\JsonApi\Adapters\SearchResultAdapter::findMany(array $resourceIds) must be compatible with CloudCreativity\LaravelJsonApi\Contracts\Adapter\ResourceAdapterInterface::findMany(iterable $resourceIds): iterable
daryledesilva commented 4 years ago

Thanks for submitting this. I hadn't spotted the stub was out of date! Just one change required to merge it.

@lindyhopchris Ok thanks! Done! If you merge my PR just squash it so it's cleaner 😁 cheers!