search

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

include query parameters in parameterOrder field #113

Closed tangiel closed 7 years ago

tangiel commented 7 years ago

Discovery has a parameterOrder field. This is seemingly used to document the order of parameters for use in client library generation. Previously, we were only including path parameters, but we need to include query parameters, so that the order is deterministic.

codecov-io commented 7 years ago

Codecov Report

Merging #113 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
+ Coverage     79.59%   79.68%   +0.08%     
- Complexity     1641     1643       +2     
============================================
  Files           156      156              
  Lines          5524     5523       -1     
  Branches        707      706       -1     
============================================
+ Hits           4397     4401       +4     
+ Misses          849      846       -3     
+ Partials        278      276       -2
Impacted Files Coverage Δ Complexity Δ
...e/api/server/spi/discovery/DiscoveryGenerator.java 87.56% <100%> (-0.07%) 51 <0> (ø)
...erver/spi/config/model/ApiSerializationConfig.java 82.75% <0%> (+6.89%) 9% <0%> (+1%) :arrow_up:
...a/com/google/api/server/spi/BackendProperties.java 100% <0%> (+10.71%) 12% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8285cc5...73d3019. Read the comment docs.